Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 1 of "find references" #355

Merged
merged 3 commits into from Nov 27, 2019

Conversation

@jackson-dean
Copy link
Member

jackson-dean commented Nov 26, 2019

Some preliminary refactoring to prepare for using the analyzer to get all references to class.

Copy link
Contributor

chriseppstein left a comment

In general, it's great if your commit messages can explain why something is happening instead of just explaining what it did. E.g. refactor: Moves initialization of block factory out of analyzer. In the description of the commit it should say something like "To use the analyzer in the vscode language server, we need to pass it the block factory that we're using locally."

packages/@css-blocks/broccoli/test/Analyze.ts Outdated Show resolved Hide resolved
For the vscode language server, we need be able to pass the block factory
instance that we've already instantiated.
@jackson-dean jackson-dean force-pushed the find-class-references branch from 21661cd to ddaed86 Nov 26, 2019
@jackson-dean jackson-dean merged commit 15c4f26 into master Nov 27, 2019
13 checks passed
13 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (chriseppstein) No new issues
Details
security/snyk - packages/@css-blocks/broccoli/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/code-style/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/core/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/ember-cli/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/glimmer/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/jsx/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/playground/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/runtime/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/webpack/package.json (chriseppstein) No manifest changes detected
security/snyk - packages/@css-blocks/website/package.json (chriseppstein) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.