Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subtypes): fix case where subtypes are not being fetched for leaf datasets #3476

Conversation

gabe-lyons
Copy link
Contributor

Subtype was only being fetched for full dataset loads, leaving leaf nodes without subtype specification until expanded.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results

     58 files  ±0       58 suites  ±0   23m 22s ⏱️ + 3m 10s
   525 tests ±0     473 ✔️ ±0  52 💤 ±0  0 ±0 
1 174 runs  ±0  1 106 ✔️ ±0  68 💤 ±0  0 ±0 

Results for commit 0ab14c9. ± Comparison against base commit 9ed0879.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 4b6860e into datahub-project:master Oct 28, 2021
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants