fix(ingest): correctly support multiple snowflake databases #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this fix, the listen_for hook would only be called for each dbapi connection. This would cause issues for us, since the dbapi connections live in a shared pool associated with each engine. To fix this fully, instead we just create a new engine for each database. This does mean that we start extra connections to the db and hence are slightly less efficient, but this is a worthwhile tradeoff for correctness.
|
LGTM! Ship it! |
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Nov 3, 2021
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Nov 6, 2021
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix, the listen_for hook would only be called for each dbapi connection. This would cause issues for us, since the dbapi connections live in a shared pool associated with each engine. To fix, we just create a new engine for each database. This does mean that we start extra connections to the db and hence are slightly less efficient, but this is a worthwhile tradeoff for ensuring correctness.
Should fix a regression introduced by #3369, which was discovered here: https://datahubspace.slack.com/archives/C029A3M079U/p1635366199095000.
This PR also contains a couple improvements in profiling logging.
Checklist