New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kafka): support confluent references #3862
feat(kafka): support confluent references #3862
Conversation
schema_seen[ref_subject] = tmp_schema | ||
logger.debug(f"ref for {ref_subject} is {tmp_schema.schema.schema_str}") | ||
schema_str = schema_str.replace( | ||
f'"{ref_name}"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the reference names always appear in double quotes? Can they be single quoted? What if this string appears in documentation? Does confluent_kafka
provider some a parser for us to more deterministically replace the reference schemas names with their schema definitions to generate a well-formed AVRO schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avro has to be valid JSON so this should be in double quotes always. confluent_kafka
does not provide any such method.
@anshbansal: could you add a unit test for this with a checked in sample schema repo with references? |
@shirshanka Unit test added. Can this be merged now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist