Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): enforce correct behaviour for commit policy #4092

Merged

Conversation

claudio-benfatto
Copy link
Contributor

fixes a bug in the CommitPolicy enum that was causing an incorrect behaviour during the pipeline process_commits stage.

class CommitPolicy(Enum):
    ALWAYS = auto
    ON_NO_ERRORS = auto
    ON_NO_ERRORS_AND_NO_WARNINGS = auto

meant that ALWAYS == ON_NO_ERRORS == ON_NO_ERRORS_AND_NO_WARNINGS that would cause an incorrect
behaviour when calling the process_commits() method in the pipeline

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

fixes a bug in the CommitPolicy enum that was causing an incorrect
behaviour during the pipeline process_commits stage
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Unit Test Results (build & test)

  68 files  ±0    68 suites  ±0   11m 58s ⏱️ - 2m 37s
596 tests ±0  537 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit c512448. ± Comparison against base commit 306fe0b.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Unit Test Results (metadata ingestion)

    3 files      3 suites   39m 29s ⏱️
313 tests 313 ✔️   0 💤 0
899 runs  872 ✔️ 27 💤 0

Results for commit c512448.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch. thanks!

@shirshanka shirshanka merged commit f944a9b into datahub-project:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants