Feature/oss/update to v2 endpoints #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/OSS/updateToV2Endpoints
jjoyce0510
reviewed
Feb 15, 2022
| Constants.ASPECT_LATEST_VERSION, | ||
| context.getAuthentication()); | ||
| return keyAspect != null; | ||
| Urn userUrn = Urn.createFromString(userUrnStr); |
There was a problem hiding this comment.
So I think previously if there was no key aspect, this would getAspectOrNull would return null... But I believe that batchGetV2 artificially injects a key aspect into the result set to maintain our previous behavior. In this particular case it won't be a huge deal but it might be in other cases... Gabe added an "exists" API in GMS that we should migrate this to instead...
Don't may not need to address in this PR, but definitely want to call it out
jjoyce0510
reviewed
Feb 15, 2022
| _datasetHydrator.hydrateFromEntityResponse(document, entityResponse); | ||
| break; | ||
| default: | ||
| log.error("Unable to find valid hydrator for entity type: {} urn: {}", entityResponse.getEntityName(), urn); |
jjoyce0510
approved these changes
Feb 15, 2022
shirshanka
approved these changes
Feb 15, 2022
hevandro-veiga
pushed a commit
to hevandro-veiga/datahub
that referenced
this pull request
Feb 18, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all internal usages of old Snapshot endpoints to V2 endpoints for Java classes