Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(website): Move company logos into tabs categorized by industry #4174

Merged
merged 2 commits into from Feb 20, 2022
Merged

docs(website): Move company logos into tabs categorized by industry #4174

merged 2 commits into from Feb 20, 2022

Conversation

jeffmerrick
Copy link
Contributor

Screen Shot 2022-02-17 at 4 13 24 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Feb 17, 2022 •
edited

Unit Test Results (build & test)

  70 files  ±0    70 suites  ±0   16m 0s ⏱️ + 3m 58s
611 tests +2  552 ✔️ +2  59 💤 ±0  0 ❌ ±0 

Results for commit c324ce0. ± Comparison against base commit c89a1f2.

♻️ This comment has been updated with latest results.

@jjoyce0510
Copy link
Collaborator

One minor comment - What's the diff between E-Commerce and B2C? These categories don't seem mutually exclusive.. Is that intentional?

@maggiehays
Copy link
Collaborator

maggiehays commented Feb 17, 2022 •
edited

One minor comment - What's the diff between E-Commerce and B2C? These categories don't seem mutually exclusive.. Is that intentional?
@jjoyce0510 @jeffmerrick Fair question... What if we rename E-Commerce to Online Marketplace?

@jjoyce0510
Copy link
Collaborator

I'd prefer just E-commerce. It's more standard. Still doesn't seem quite right.. Since Peloton could be considered ecommerce. Maybe not time to slice these upp..

shirshanka
shirshanka approved these changes Feb 20, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 33de579 into datahub-project:master Feb 20, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@jeffmerrick @maggiehays
docs(website): Move company logos into tabs categorized by industry (d…
110b096 
…atahub-project#4174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeffmerrick @jjoyce0510 @maggiehays @shirshanka