Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update postgres.md #4292

Merged
merged 1 commit into from Mar 7, 2022
Merged

docs: Update postgres.md #4292

merged 1 commit into from Mar 7, 2022

Conversation

BoyuanZhangDE
Copy link
Contributor

@BoyuanZhangDE BoyuanZhangDE commented Mar 2, 2022 •
edited

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

[postgres]: update the platform_instance field of postgres ingestion doc

Add the platform_instance field in postgres doc, after testing this field functions normally.

No BREAKING CHANGE

@BoyuanZhangDE BoyuanZhangDE changed the title Update postgres.md docs: Update postgres.md Mar 2, 2022
shirshanka
shirshanka approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   46m 11s ⏱️ + 1m 40s
   343 tests ±0     343 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 562 runs  ±0  1 524 ✔️ ±0  38 💤 ±0  0 ❌ ±0 

Results for commit ec900e7. ± Comparison against base commit 2a5cf3d.

@shirshanka shirshanka merged commit e2d05cd into datahub-project:master Mar 7, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@BoyuanZhangDE @maggiehays
docs: postgres - update support for platform instance (datahub-projec…
2e118ee 
…t#4292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BoyuanZhangDE @shirshanka @jjoyce0510