Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tags) - map tags to globalTags for entities #4310

Merged
merged 1 commit into from Mar 4, 2022

Conversation

aditya-radhakrishnan
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Unit Test Results (build & test)

  71 files  ±0    71 suites  ±0   12m 17s ⏱️ +28s
618 tests ±0  559 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 0364479. ± Comparison against base commit d96241c.

@@ -27,6 +27,12 @@ export function getDataForEntityType<T>({
customProperties,
};
}
if (anyEntityData.tags) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just please make sure this works for datasets, charts, dashboards as well.

@shirshanka shirshanka merged commit 08aab88 into datahub-project:master Mar 4, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants