Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to enable SSL for Dr.Elephant #656

Merged

Conversation

ShubhamGupta29
Copy link
Contributor

DESCRIPTION
This PR contains changes to adding support to Enable SSL for Dr.Elephant given the user has verified certificate and other configs needed. The config needed to enable SSL are present in elephant.conf and should be un-commented to enable SSL. This will help in increasing security for Dr.Elephant and also would make Dr.Elephant to be contacted by other secure services/apps.

HOW THESE CHANGES ARE TESTED
Tested these changes on the local machine with a self-signed certificate and also tested it on EI environment with a CA certified certificate.

@ShubhamGupta29 ShubhamGupta29 self-assigned this Feb 17, 2020
@ShubhamGupta29 ShubhamGupta29 changed the base branch from tuning_20190221 to master February 17, 2020 10:58
@ShubhamGupta29 ShubhamGupta29 changed the base branch from master to tuning_20190221 February 17, 2020 10:58
@ShubhamGupta29 ShubhamGupta29 linked an issue Feb 17, 2020 that may be closed by this pull request
@pralabhkumar
Copy link
Contributor

LGTM

@pralabhkumar pralabhkumar merged commit 99ae6af into linkedin:tuning_20190221 Feb 17, 2020
ShubhamGupta29 added a commit that referenced this pull request Feb 17, 2020
@ShubhamGupta29 ShubhamGupta29 deleted the https_enablement branch April 13, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to enable ssl for Dr. Elephant
2 participants