making InMemoryStorage an abstract DocumentBinaryStorage #26

merged 1 commit into from Feb 5, 2012


None yet
2 participants

dbuthay commented Feb 3, 2012

.. and implementing it in-memory ..

This PR separates InMemoryStorage in 2 classes:

  • DocumentBinaryStorage: an storage agnostic class that basically Serializes / compresses Documents in an efficitent way
  • InMemoryStorage: a subclass of the above, that uses a Map<String, byte[]> to store the values.

Other possible subclasses extending DocumentBinaryStorage would be a krati storage, maybe a BerkeleyDB storage, or even a LevelDB storage.

BTW, I already have a working Krati version based on this branch on dbuthay/indextank-engine@2718a9e

iladriano merged commit 14930c8 into linkedin:master Feb 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment