…indow scope This change closes a bug where the `downloadCompleteQueue` was getting leaked in to the window scope. To fix this, a reference from `self` was changed to `this`. Since it was tied to clearing the caches, this fix doesn't introduce a backwards incompatible change.
…catch for an IE8 alternative
…make IE8 happy
…lied when multiple sheets are fetched
The lscache object was undefined due to the refactoring of the communicator. This change converts the communicator calls to this.env.cache. The tests were updated to ensure travis ci passes. Original author: @chrisamaral Fixes #306 This is a recommended patch for all 0.7.0 users and will result in a 0.7.1 build.
* chrisamaral-master: fix: lscache was referenced as `cache` in InjectContext.env but communicator.js wasn't refactored thus whenever readFromCache was called it would hit undefined. Also, the cache property was not actually imported into InjectContext. I also updated the distribution and recompiled it with closure (not too familiar with grunt), which works just fine, in case anyone looking for a quick fix. use svg image instead of png for travisCI badge on readme
…nicator.js wasn't refactored thus whenever readFromCache was called it would hit undefined. Also, the cache property was not actually imported into InjectContext. I also updated the distribution and recompiled it with closure (not too familiar with grunt), which works just fine, in case anyone looking for a quick fix.
This resolves a problem with define() calls that did not declare a dependency array, but had an array immediately defined at the top of their factory function. In these cases, the array was being identified as dependencies. To resolve this, the Inject reject for define() now scans for [^)] instead of the prior [\w\W] pattern.
After fixing the stacktrace normalization, the PhantomJS output needed to be accounted for when using pure stacktrace-js. The solution was to capture and handle the normalized stacktrace-js output with a regex. Combines with the previous push as part of #302 to ensure all tests are passing in automation.
This fixes the stacktrace.js integration in two important ways. First, the library is now beign included externally (much like Fiber). Second, the stack normalization guards against invalid or unparsable traces (noticed in IE8 compatibility mode). As part of the migration to the external stacktrace-js library, the tests were updated to reference their node_module version. This will ensure for both stacktrace-js and Fiber we are referencing the proper version that is being built with during our unit tests. Fixes #301
…ules By default, the behavior of fetch rules was to return cb('') when the module exists. For AMD-like modules, this is undersirable since AMD modules can be dynamic by nature. This fix protects the if checks by ensuring we are looking at an AMD-like module before running these tests.
the extras for inject surrounding the non AMD plugins were never modified to work with the new instance based designs. This change allows a global INJECT_PLUGINS object to exist, which can then be plugged in to. BREAKING CHANGE The prior inject-plugins.js file is no longer a part of recent, and the plugins need to be included indivudally. Additionally, a plugin needs to be enabled by passing the instance of Inject to the plugin method: INJECT_PLUGINS.css(Inject); // adds the CSS plugin to the current instance