Permalink
Browse files

Change some degrader logging messages from 'warn' to 'info'

D2 Degrader logs the state change as warning message when computedDropRate changes. Change it to 'info' when the client
is recovering. This helps to reduce the total number of warning messages.

RB=1234469
G=si-core-reviewers
R=ssheng,dhoa,fcapponi
A=ssheng
  • Loading branch information...
ChaoLinkedIn committed Feb 27, 2018
1 parent 1985000 commit c1ce56b988c74c35883d5189f9c865037213103d
Showing with 17 additions and 3 deletions.
  1. +5 −0 CHANGELOG
  2. +11 −2 degrader/src/main/java/com/linkedin/util/degrader/DegraderImpl.java
  3. +1 −1 gradle.properties
@@ -1,5 +1,10 @@
20.0.3
------
20.0.2
------
(RB=1234469)
Change some degrader logging messages from 'warn' to 'info'
20.0.1
------
@@ -376,7 +376,7 @@ else if (oldDropRate > 0.0 && isLow())
if (oldDropRate != newDropRate && log.isWarnEnabled() && newDropRate >= _config.getLogThreshold())
{
log.warn(_config.getName() + " ComputedDropRate " +
String logMessage = _config.getName() + " ComputedDropRate " +
(oldDropRate > newDropRate ? "decreased" : "increased") +
" from " + oldDropRate + " to " + newDropRate +
", OverrideDropRate=" + _config.getOverrideDropRate() +
@@ -388,7 +388,16 @@ else if (oldDropRate > 0.0 && isLow())
", OutstandingCount=" + stats.getOutstandingCount() +
", NoOverrideDropCountTotal=" + noOverrideDropCountTotal +
", DroppedCountTotal=" + droppedCountTotal +
", LastIntervalDroppedRate=" + lastIntervalDroppedRate);
", LastIntervalDroppedRate=" + lastIntervalDroppedRate;
if (oldDropRate < newDropRate)
{
// Log as 'warn' only if dropRate is increasing
log.warn(logMessage);
}
else
{
log.info(logMessage);
}
}
else
{
@@ -1,4 +1,4 @@
version=20.0.1
version=20.0.2
sonatypeUsername=please_set_in_home_dir_if_uploading_to_maven_central
sonatypePassword=please_set_in_home_dir_if_uploading_to_maven_central
org.gradle.configureondemand=true

0 comments on commit c1ce56b

Please sign in to comment.