small feature of bql template #56

Open
wants to merge 14 commits into
from

3 participants

@sguo
LinkedIn member

No description provided.

@bcui

Hi Sheng,

What is the need for this empty_predicate? Can you add a test case? Why do we have to change CONTAINS ALL for this? We also need to consider the variable cases.

Baoqiu

LinkedIn member

Hi Baoqiu,
This is needed by Carrie. They need a simple grammar like "where $list is empty or FACET contains all $list". That means if the list is empty the second boolean check is short-circuited. So that's the reason they want a empty check statement for value list. It may help to maintain a clean BQL template. After this requirement is popped, we had some discussion, and just quickly made this feature for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment