Skip to content

Removing inMemorySenseiServiceClass, which improperly uses of JVM. #78

Open
wants to merge 1 commit into from

3 participants

@khayashi

Details in
https://iwww.corp.linkedin.com/wiki/cf/display/ENGS/Sensei+JMX+NPE+Problem
Seas doesn’t use this class. Removing this class and associated classes
to prevent future use.
CNC version of Sensei causes a issue. JIra - SI 571.

Ran Sensei test and Seas test. Passed both.

@khayashi khayashi Removing inMemorySenseiServiceClass, which improperly uses of JVM.
Details in
https://iwww.corp.linkedin.com/wiki/cf/display/ENGS/Sensei+JMX+NPE+Problem
Seas doesn’t use this class. Removing this class and associated classes
to prevent future use.
CNC version of Sensei causes a issue. JIra - SI 571.

Ran Sensei test and Seas test. Passed both.
5fda5e1
@khayashi

Santi,

Could you please review this ?

@zhuang
LinkedIn member
zhuang commented Apr 17, 2013

Is it possible to fix it instead of removing?

@santip
santip commented Apr 17, 2013

Not much to review here you're merely removing a piece of the code.

A few questions:
1) is this used anywhere in our projects?
2) is this still used in CNC projects? if so, are you proposing that we diverge perpetually?
3) where were the PCL failures triggered? if it was in CNC projects, how will this fix the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.