[protocol] Add PartitionState v21 with HLL sketch field#2707
Merged
Conversation
pthirun
changed the title
pthirun
force-pushed
the
pthiruna/hll-partition-state-v21
branch
3 times, most recently
from
10a0d24 to
c6bae42
Compare
…field Add nullable bytes field for HLL sketch persistence. This schema change is a prerequisite for the HLL-based unique key count feature (PR linkedin#2671). New field: uniqueIngestedKeyCountHllSketch: ["null", "bytes"], default: null Backward compatible: old servers ignore the new field (has default), new servers reading old data see null. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pthirun
force-pushed
the
pthiruna/hll-partition-state-v21
branch
from
c6bae42 to
2afed76
Compare
sixpluszero
approved these changes
Apr 8, 2026
pthirun
added a commit
to pthirun/venice
that referenced
this pull request
Apr 8, 2026
- Remove PartitionState v21 schema file (landed separately in PR linkedin#2707) - Remove v20 version pin from build.gradle versionOverrides (activates v21) - AvroProtocolDefinition already at v21 from prior commits Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pthirun
added a commit
to pthirun/venice
that referenced
this pull request
Apr 8, 2026
…onState v20" This reverts commit a29124b.
pthirun
added a commit
to pthirun/venice
that referenced
this pull request
Apr 8, 2026
Activates PartitionState v21 schema (landed in PR linkedin#2707). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
11 tasks
pthirun
added a commit
to pthirun/venice
that referenced
this pull request
Apr 9, 2026
- Remove PartitionState v21 schema file (landed separately in PR linkedin#2707) - Remove v20 version pin from build.gradle versionOverrides (activates v21) - AvroProtocolDefinition already at v21 from prior commits Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pthirun
added a commit
to pthirun/venice
that referenced
this pull request
Apr 9, 2026
…onState v20" This reverts commit a29124b.
pthirun
added a commit
to pthirun/venice
that referenced
this pull request
Apr 9, 2026
Activates PartitionState v21 schema (landed in PR linkedin#2707). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
PR #2671 adds HLL-based unique key count tracking that needs to persist the HLL sketch in the partition checkpoint. This requires a new field in the PartitionState Avro schema. CI policy requires schema changes in a separate PR.
Solution
Add PartitionState v21 with one new nullable bytes field and bump the protocol version.
New field:
uniqueIngestedKeyCountHllSketch(nullable bytes, default null). ~8KB when populated at lgK=13.Code changes
Concurrency-Specific Checks
How was this PR tested?
Does this PR introduce any user-facing or breaking changes?