Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowercase host headers in http identifier #106

Closed
olix0r opened this Issue Feb 16, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@olix0r
Copy link
Member

olix0r commented Feb 16, 2016

From RFC 2616:

        - Comparisons of host names MUST be case-insensitive;

In order to live this life, ensure that the host header value is lowercased before being inserted into a Dst.Path.

@olix0r olix0r added the ready label Feb 16, 2016

@klingerf klingerf removed the ready label Feb 23, 2016

@klingerf klingerf added the ready label Apr 30, 2016

@olix0r olix0r added the help wanted label Sep 12, 2016

ashald added a commit to ashald/linkerd that referenced this issue Sep 13, 2016

ashald added a commit to ashald/linkerd that referenced this issue Sep 13, 2016

adleong added a commit that referenced this issue Sep 14, 2016

Lowercase Host header value in HTTP identifier (#664)
In accordance to RFC 2616. Handles #106
@ashald

This comment has been minimized.

Copy link
Member

ashald commented Sep 28, 2016

Close it?

@adleong adleong closed this Sep 28, 2016

@adleong adleong removed the ready label Sep 28, 2016

tbrooks8 pushed a commit to tbrooks8/linkerd that referenced this issue Dec 20, 2018

Better error handling for Tap (linkerd#177)
Previously, running `$conduit tap` would return a `Unexpected EOF` error when the server wasn't available. This was due to a few problems with the way we were handling errors all the way down the tap server. This change fixes that and cleans some of the protobuf-over-HTTP code.

- first step towards linkerd#49
- closes linkerd#106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.