New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namer plugin that have Admin.WithNavItems or Admin.WithHandlers are not added to the admin UI #1716

Closed
robertpanzer opened this Issue Nov 29, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@robertpanzer
Copy link
Contributor

robertpanzer commented Nov 29, 2017

Issue Type:

  • Bug report
  • Feature request

What happened:
Plugins can extend the admin UI by adding the trait Admin.WithHandlers and possibly Admin.WithNavItems.
After implementing the respective methods on a Namer the item doesn't appear in the UI while it works for other plugin types, e.g. Telemetry plugins or Identifiers.

What you expected to happen:
I expect that the item appears, just as it would appear when adding the traits for example to an Identifier or Telemetry plugin

How to reproduce it (as minimally and precisely as possible):
Add the traits to any Namer plugin, e.g.

class FooNamer extends Namer with Admin.WithHandlers with Admin.WithNavItems {
  val adminHandlers = Seq(Handler("/foo", new FooHandler()))
  val navItems = Seq(Admin.NavItem(name = "foo", url = "/foo"))
  ...
}

Anything else we need to know?:
The root of the problem seems to be place where io.buoyant.linkerd.admin.LinkerdAdmin.apply() collects the plugins.
The namers are stored as a set of Tuples (Path,Namer), but that method checks if the tuple has this trait instead of the second member.

I can provide a PR for this.

Environment:

  • linkerd/namerd version, config files: 1.3.2
  • Platform, version, and config files (Kubernetes, DC/OS, etc): OS X, plain installation
  • Cloud provider or hardware configuration: Local

robertpanzer pushed a commit to robertpanzer/linkerd that referenced this issue Nov 29, 2017

@siggy siggy added this to the 1.3.3 milestone Nov 30, 2017

@siggy siggy closed this in 5188f55 Nov 30, 2017

tbrooks8 pushed a commit to tbrooks8/linkerd that referenced this issue Dec 20, 2018

Added a help section to the sidebar (linkerd#1764)
Adding some quick links and help to the sidebar to guide users that 
are stuck the channels that are most relevant

Fixes linkerd#1716

Signed-off-by: Ben Lambert <ben@blam.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment