Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase circleci resource class to large #2143

Merged
merged 1 commit into from Oct 8, 2018
Merged

Increase circleci resource class to large #2143

merged 1 commit into from Oct 8, 2018

Conversation

adleong
Copy link
Member

@adleong adleong commented Oct 8, 2018

This should hopefully prevent Linkerd tests from getting terminated for using to memory.

Signed-off-by: Alex Leong alex@buoyant.io

Signed-off-by: Alex Leong <alex@buoyant.io>
@adleong adleong self-assigned this Oct 8, 2018
@adleong adleong requested a review from olix0r as a code owner October 8, 2018 16:40
Copy link
Member

@siggy siggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending a successful ci run ;)

@@ -18,7 +18,7 @@ class ExamplesTest extends FunSuite {
for (file <- files) {
// Example tests are running out of memory in CI and so have been temporarily been disabled to
// unblock CI. This needs to be investigated and fixed.
ignore(file.getName) {
test(file.getName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@dadjeibaah dadjeibaah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 📦

@adleong adleong merged commit e1afd01 into master Oct 8, 2018
@adleong adleong deleted the alex/so-classy branch October 8, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants