Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add ability to see breakdown of requests by fate #2016
What problem are you trying to solve?
Setting up retries can be confusing and it can be difficult to determine if retries have been configured successfully. Furthermore, it can be very difficult to know WHY retries are or are not happening. Showing effective and actual RPS can show whether retries are happening, but do not explain why. For example, retries may be skipped for a variety of reasons including:
How should the problem be solved?
All requests that the Linkerd proxy sends fall into exactly one of these categories:
To be able to distinguish between success (first try) and success (after retry), we would probably need to add a new prometheus label that indicates if an actual request is an original request or a retry.
This feels valuable, but does it need to be added to
There is a subtle but important difference between this and stat/routes. Stat and routes both default to showing inbound data i.e. what is the success rate of requests the target receives. This behavior is flipped to show outbound data if the
These retry stats, on the other hand, ONLY make sense for outbound data (there are no inbound retries). So defaulting to inbound like stat/routes wouldn't make sense. So we would need to somehow make it clear that this command works differently and always shows data about requests that the target resource is sending (as opposed to receiving).