Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configs Override For CLI-Injected Workloads #2590

Closed
ihcsim opened this issue Mar 28, 2019 · 2 comments

Comments

@ihcsim
Copy link
Member

commented Mar 28, 2019

This is a stable-2.4 follow-up task for #2498 (comment). In stable-2.3, we have decided to postpone the support of overriding configs for existing CLI-injected workloads, due to reasons described in the above comment and #2576.

The focus of this task is to ensure that following #2576, the configs override of existing CLI-injected workloads work. Depending on the implementation decision of #2576, if the proxy spec is removed from the output of linkerd inject, then no changes to the webhook will be necessary, as the webhook will pick up the pod (during CREATE) and mutate its pod spec to include the proxy container.

@ihcsim ihcsim added the area/inject label Mar 28, 2019

@ihcsim ihcsim added this to To do in Inject/Install Configuration via automation Mar 28, 2019

@ihcsim ihcsim added this to To do in 2.4 - Debt via automation Apr 17, 2019

@ihcsim

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

Depends on #2710 #2711 #2715

@ihcsim ihcsim self-assigned this Apr 24, 2019

@ihcsim ihcsim moved this from To do to In progress in 2.4 - Debt Apr 24, 2019

@ihcsim

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

Fixed by #2710 #2711 #2715

@ihcsim ihcsim closed this Apr 24, 2019

Inject/Install Configuration automation moved this from To do to Done Apr 24, 2019

2.4 - Debt automation moved this from In progress to Done Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.