Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit Proxy Spans #3188

Open
grampelberg opened this issue Aug 2, 2019 · 5 comments

Comments

@grampelberg
Copy link
Member

commented Aug 2, 2019

What problem are you trying to solve?

When viewing distributed traces, it is beneficial to see the spans associated with proxies alongside those emitted by applications. This allows users to understand what overhead proxies are adding to their applications.

As this feature has serious performance implications and requires application changes to be useful, it must be configurable and disabled by default.

How should the problem be solved?

Out of scope

  • Installing and configuring the OpenTelemetry service.
  • Exporting any metadata outside of timing.

@grampelberg grampelberg added the rfc label Aug 2, 2019

@grampelberg

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Related to #1436.

@adleong

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

It's worth noting that OpenCensus does not use the Trace-Context propagation format for gRPC requests. Instead, it uses a header called grpc-trace-bin: https://github.com/census-instrumentation/opencensus-specs/blob/master/trace/gRPC.md

This means that Linkerd must also read this header if it wishes to participate in gRPC traces.

@adleong

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

If installing and configuring the OpenTelemetry service is out of scope, it becomes more difficult to send traces to the agent over TLS. The agent's trust root would need to be mounted into the proxy's container and thus the configuration gets a bit more complex.

@olix0r

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

If installing and configuring the OpenTelemetry service is out of scope, it becomes more difficult to send traces to the agent over TLS. The agent's trust root would need to be mounted into the proxy's container and thus the configuration gets a bit more complex.

it probably means we aught to have the proxy support the environment variables needed to read a trust root from disk; and leave it as an exercise to the user to get that mounted in the proxy's container...

@olix0r

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

image

Given a trace like the above, how should this change when the proxy is participating in tracing? @grampelberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.