New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove per-path metrics from telemetry pipeline #317

Merged
merged 5 commits into from Feb 9, 2018

Conversation

Projects
None yet
2 participants
@hawkw
Copy link
Member

hawkw commented Feb 9, 2018

Follow-up from #315.

Now that the UIs don't report per-path metrics, we can remove the path label from Prometheus, the path aggregation and filtering options from the telemetry API, and the path field from the proxy report API.

I've modified the tests to no longer expect the removed fields, and manually verified that Conduit still works after making these changes.

Closes #265

hawkw added some commits Feb 9, 2018

Remove per-path metrics from controller telemetry pipeline
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Remove path metrics from proxy telemetry pipeline
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Fix "incorrect label cardinality" errors in prometheus
Signed-off-by: Eliza Weisman <eliza@buoyant.io>

@hawkw hawkw added this to the Conduit 0.3 milestone Feb 9, 2018

@hawkw hawkw self-assigned this Feb 9, 2018

@hawkw hawkw requested review from olix0r and adleong Feb 9, 2018

@hawkw hawkw added the review/ready label Feb 9, 2018

Remove path labels from grpc_server_test.go
Signed-off-by: Eliza Weisman <eliza@buoyant.io>

@hawkw hawkw requested review from pcalcado and siggy Feb 9, 2018

Remove per-pod metrics aggregation (#320)
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@adleong

adleong approved these changes Feb 9, 2018

Copy link
Member

adleong left a comment

⭐️ 👨‍🌾 this looks good to me

@hawkw hawkw merged commit 458e9d2 into master Feb 9, 2018

2 checks passed

DCO All commits have a DCO sign-off from the author
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkw hawkw removed the review/ready label Feb 9, 2018

@olix0r olix0r deleted the eliza/rm-path-metric-reporting branch Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment