Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify some gRPC status codes as non-errors #3736

Open
wants to merge 1 commit into
base: master
from

Conversation

@tegioz
Copy link
Collaborator

tegioz commented Nov 18, 2019

Linkerd classifies all gRPC status codes except OK as errors. This can negatively affect a gRPC server's success rate, even when it is only returning things like NOT_FOUND or INVALID_ARGUMENT.

This change narrows down the list of gRPC status codes that are considered an error to:

  • UNKNOWN (2)
  • DEADLINE_EXCEEDED (4)
  • INTERNAL (13)
  • UNAVAILABLE (14)
  • DATA_LOSS (15)

Please see this linkerd2 issue for more details.

This PR depends on linkerd/linkerd2-proxy#395.

Closes #3729

Signed-off-by: Sergio Castaño Arteaga tegioz@icloud.com

@tegioz tegioz force-pushed the tegioz/grpc-success-status-codes branch from d2adfac to 6fc6d3a Nov 18, 2019
@tegioz tegioz self-assigned this Nov 18, 2019
Copy link
Member

adleong left a comment

This looks like a good short term solution. The full long term solution would be to implement #1948

Signed-off-by: Sergio Castaño Arteaga <tegioz@icloud.com>
@tegioz tegioz force-pushed the tegioz/grpc-success-status-codes branch from 6fc6d3a to ba00941 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.