Respect $KUBECONFIG env var #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcalcado
force-pushed
the
phil/should-respect-KUBECONFIG-env
branch
from
a12cd76
to
ff53a10
Compare
pcalcado
force-pushed
the
phil/should-respect-KUBECONFIG-env
branch
from
ff53a10
to
af761b4
Compare
klingerf
force-pushed
the
phil/should-respect-KUBECONFIG-env
branch
from
af761b4
to
5eec58e
Compare
pcalcado
force-pushed
the
phil/should-respect-KUBECONFIG-env
branch
2 times, most recently
from
e91ad2a
to
f35c57d
Compare
klingerf
approved these changes
Dec 20, 2017
cli/shell/shell_test.go
Outdated
| home := shell.HomeDir() | ||
| expected := os.Getenv("HOME") | ||
| if runtime.GOOS != "windows" && !strings.Contains(home, expected) { | ||
| t.Errorf("This is a UNIX-like system, expecting home dir [%s] to contain [/home]", expected) |
There was a problem hiding this comment.
I think this error would make more sense as:
t.Errorf("This is a UNIX-like system, expecting home dir [%s] to contain [%s]", home, expected)
cli/k8s/api.go
Outdated
|
|
||
| "github.com/runconduit/conduit/cli/shell" | ||
| "k8s.io/client-go/rest" | ||
| ) |
There was a problem hiding this comment.
Mind collapsing the blank lines here and re-saving with goimports?
There was a problem hiding this comment.
Weird, I configured IntelliJ to use goimports upon save automatically
cli/k8s/api_test.go
Outdated
| } | ||
|
|
||
| if actualUrl.String() != expectedUrlString { | ||
| t.Fatalf("Expected generated URl to be [%s], but got [%s]", expectedUrlString, actualUrl.String()) |
cli/k8s/k8s_test.go
Outdated
| } | ||
| }) | ||
|
|
||
| t.Run("Return error it extra path doesn'' start with slash", func(t *testing.T) { |
pcalcado
force-pushed
the
phil/should-respect-KUBECONFIG-env
branch
from
f35c57d
to
d50c7d6
Compare
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
In order to start dismantling the monolithic ctx structures, this change removes the root `ctx::Process` type. This simplifies `ctx::Proxy` such that is copyable and need not be `Arc`ed. `telemetry::metrics::labels::Direction` has been updated to decorate `ctx::Proxy` instead of modeling the same variants directly as an enum.
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
Following linkerd#67 and linkerd#68, the `labels::Direction` type can be replaced with an `impl FmtLabels for ctx::Proxy`.
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
Following linkerd#67 and linkerd#68, the `labels::TlsStatus` type can be removed in favor of extending underlying `ctx::transport::TlsStatus` type to implement `FmtLabels`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts some of the kube api creatin logic into its own object, and makes sure that it respects the
$KUBECONFIGvariable. It would probably be more interesting to use something like Kubernetes' own logic to deal with this, but this is not in scope for this issue.Closes #17