From 9987bb06f0f3732068f767459390fc8805b709e1 Mon Sep 17 00:00:00 2001 From: Vikram Tiwari Date: Sat, 27 Aug 2016 13:12:31 -0700 Subject: [PATCH] remove traces of jshint fixed all warnings for standard linter removed jshint tasks removed jshintrc and ignore files removed from package.json --- .jshintignore | 1 - .jshintrc | 92 --------------------------------------------- gulp/development.js | 4 +- package.json | 3 -- webpack.config.js | 31 ++++++++------- 5 files changed, 17 insertions(+), 114 deletions(-) delete mode 100644 .jshintignore delete mode 100644 .jshintrc diff --git a/.jshintignore b/.jshintignore deleted file mode 100644 index 5fca523fec..0000000000 --- a/.jshintignore +++ /dev/null @@ -1 +0,0 @@ -test/coverage/** \ No newline at end of file diff --git a/.jshintrc b/.jshintrc deleted file mode 100644 index d44da6af47..0000000000 --- a/.jshintrc +++ /dev/null @@ -1,92 +0,0 @@ -{ - "maxerr" : 50, // {int} Maximum error before stopping - - // Enforcing - "bitwise" : true, // true: Prohibit bitwise operators (&, |, ^, etc.) - "camelcase" : false, // true: Identifiers must be in camelCase - "curly" : false, // true: Require {} for every new block or scope - "eqeqeq" : true, // true: Require triple equals (===) for comparison - "forin" : false, // true: Require filtering for..in loops with obj.hasOwnProperty() - "immed" : true, // true: Require immediate invocations to be wrapped in parens e.g. `(function () { } ());` - "indent" : 2, // {int} Number of spaces to use for indentation - "latedef" : true, // true: Require variables/functions to be defined before being used - "newcap" : true, // true: Require capitalization of all constructor functions e.g. `new F()` - "noarg" : true, // true: Prohibit use of `arguments.caller` and `arguments.callee` - "noempty" : true, // true: Prohibit use of empty blocks - "nonew" : true, // true: Prohibit use of constructors for side-effects (without assignment) - "plusplus" : false, // true: Prohibit use of `++` & `--` - "quotmark" : "single", // Quotation mark consistency: - // false : do nothing (default) - // true : ensure whatever is used is consistent - // "single" : require single quotes - // "double" : require double quotes - "undef" : true, // true: Require all non-global variables to be declared (prevents global leaks) - "unused" : "vars", // true: Require all defined variables be used - "strict" : true, // true: Requires all functions run in ES5 Strict Mode - "maxparams" : false, // {int} Max number of formal params allowed per function - "maxdepth" : false, // {int} Max depth of nested blocks (within functions) - "maxstatements" : false, // {int} Max number statements per function - "maxcomplexity" : false, // {int} Max cyclomatic complexity per function - "maxlen" : false, // {int} Max number of characters per line - - // Relaxing - "asi" : true, // true: Tolerate Automatic Semicolon Insertion (no semicolons) - "boss" : false, // true: Tolerate assignments where comparisons would be expected - "debug" : false, // true: Allow debugger statements e.g. browser breakpoints. - "eqnull" : false, // true: Tolerate use of `== null` - "es5" : false, // true: Allow ES5 syntax (ex: getters and setters) - "esnext" : true, // true: Allow ES.next (ES6) syntax (ex: `const`) - "moz" : false, // true: Allow Mozilla specific syntax (extends and overrides esnext features) - // (ex: `for each`, multiple try/catch, function expression…) - "evil" : false, // true: Tolerate use of `eval` and `new Function()` - "expr" : false, // true: Tolerate `ExpressionStatement` as Programs - "funcscope" : false, // true: Tolerate defining variables inside control statements - "globalstrict" : false, // true: Allow global "use strict" (also enables 'strict') - "iterator" : false, // true: Tolerate using the `__iterator__` property - "lastsemic" : false, // true: Tolerate omitting a semicolon for the last statement of a 1-line block - "laxbreak" : false, // true: Tolerate possibly unsafe line breakings - "laxcomma" : false, // true: Tolerate comma-first style coding - "loopfunc" : false, // true: Tolerate functions being defined in loops - "multistr" : false, // true: Tolerate multi-line strings - "proto" : false, // true: Tolerate using the `__proto__` property - "scripturl" : false, // true: Tolerate script-targeted URLs - "shadow" : false, // true: Allows re-define variables later in code e.g. `var x=1; x=2;` - "sub" : false, // true: Tolerate using `[]` notation when it can still be expressed in dot notation - "supernew" : false, // true: Tolerate `new function () { ... };` and `new Object;` - "validthis" : false, // true: Tolerate using this in a non-constructor function - - // Environments - "browser" : true, // Web Browser (window, document, etc) - "couch" : false, // CouchDB - "devel" : true, // Development/debugging (alert, confirm, etc) - "dojo" : false, // Dojo Toolkit - "jquery" : false, // jQuery - "mootools" : false, // MooTools - "node" : true, // Node.js - "nonstandard" : false, // Widely adopted globals (escape, unescape, etc) - "prototypejs" : false, // Prototype and Scriptaculous - "rhino" : false, // Rhino - "worker" : false, // Web Workers - "wsh" : false, // Windows Scripting Host - "yui" : false, // Yahoo User Interface - - // Custom Globals - "globals": { - "$" : true, - "angular" : true, - "define" : false, - "jasmine" : false, - "require" : false, - "exports" : false, - "module" : false, - "describe" : false, - "before" : false, - "beforeEach" : false, - "after" : false, - "afterEach" : false, - "it" : false, - "inject" : false, - "expect" : false, - "spyOn" : false - } -} diff --git a/gulp/development.js b/gulp/development.js index f8683cae37..56299291ae 100644 --- a/gulp/development.js +++ b/gulp/development.js @@ -16,7 +16,7 @@ var paths = { var webpack = require('webpack') var webpackConfig = require('../webpack.config.js') -// var defaultTasks = ['clean', 'jshint', 'less', 'csslint', 'devServe', 'watch'] +// var defaultTasks = ['clean', 'standard', 'less', 'csslint', 'devServe', 'watch'] var defaultTasks = ['webpack:build-dev', 'clean', 'less', 'sass', 'csslint', 'devServe', 'watch'] gulp.task('env:development', function () { @@ -122,7 +122,7 @@ gulp.task('watch', function () { interval: 500 }) - gulp.watch(paths.js, ['jshint']) + gulp.watch(paths.js, ['standard']) gulp.watch(paths.css, ['csslint']).on('change', plugins.livereload.changed) gulp.watch(paths.less, ['less']) gulp.watch(paths.sass, ['sass']) diff --git a/package.json b/package.json index 5281e61489..76c74b0265 100644 --- a/package.json +++ b/package.json @@ -67,7 +67,6 @@ "gulp-concat": "latest", "gulp-csslint": "latest", "gulp-cssmin": "latest", - "gulp-jshint": "latest", "gulp-less": "latest", "gulp-livereload": "latest", "gulp-load-plugins": "latest", @@ -80,8 +79,6 @@ "jasmine": "latest", "jasmine-reporters": "latest", "jquery": "latest", - "jshint": "latest", - "jshint-stylish": "latest", "jsonwebtoken": "latest", "karma": "latest", "karma-chrome-launcher": "latest", diff --git a/webpack.config.js b/webpack.config.js index ec6f9ea376..c7bd792a43 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -13,26 +13,25 @@ module.exports = { filename: 'app.js' }, module: { - loaders: [ - {test: /\.css$/, loader: 'style-loader!css-loader'}, - { - test: /\.js$/, - exclude: /(node_modules|bower_components|lib)/, - loader: 'babel?presets[]=es2015&presets[]=stage-1' - }, - { - test: /(.*)\.(eot|svg|ttf|woff|woff2)$/, - loader: 'url-loader' - } - ] + loaders: [{ + test: /\.css$/, + loader: 'style-loader!css-loader' + }, { + test: /\.js$/, + exclude: /(node_modules|bower_components|lib)/, + loader: 'babel?presets[]=es2015&presets[]=stage-1' + }, { + test: /(.*)\.(eot|svg|ttf|woff|woff2)$/, + loader: 'url-loader' + }] }, resolve: { modulesDirectories: ['bower_components', 'node_modules'] }, plugins: [ - /* new ngAnnotatePlugin({ - add: true, - // other ng-annotate options here - })*/ + // new ngAnnotatePlugin({ + // add: true, + // // other ng-annotate options here + // }) ] }