New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved bootstrap from head to assets as dependency #1290

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@VikramTiwari
Member

VikramTiwari commented Jul 31, 2015

moving towards css frameworks as packages

@emps

This comment has been minimized.

Show comment
Hide comment
@emps

emps Aug 1, 2015

Contributor

this can make problems with bootstrap fonts

Contributor

emps commented Aug 1, 2015

this can make problems with bootstrap fonts

@VikramTiwari

This comment has been minimized.

Show comment
Hide comment
@VikramTiwari

VikramTiwari Aug 1, 2015

Member

@emps Okay! But didn't understood why would it?

Member

VikramTiwari commented Aug 1, 2015

@emps Okay! But didn't understood why would it?

@shailendramonu

This comment has been minimized.

Show comment
Hide comment
@shailendramonu

shailendramonu Aug 1, 2015

No font icons will be loaded after this change. Check on console...

On Saturday, 1 August 2015, Karol notifications@github.com wrote:

this can make problems with bootstrap fonts


Reply to this email directly or view it on GitHub
#1290 (comment).

Thanks & Regards,
Shailendra Singh

No font icons will be loaded after this change. Check on console...

On Saturday, 1 August 2015, Karol notifications@github.com wrote:

this can make problems with bootstrap fonts


Reply to this email directly or view it on GitHub
#1290 (comment).

Thanks & Regards,
Shailendra Singh

@emps

This comment has been minimized.

Show comment
Hide comment
@emps

emps Aug 1, 2015

Contributor

@VikramTiwari cause all scripts in production mode gonna be at bower_components/build/* where will be missing fonts icons... bootstrap looking for his fonts in his original folder see how gulp works at gulp/ folder

Contributor

emps commented Aug 1, 2015

@VikramTiwari cause all scripts in production mode gonna be at bower_components/build/* where will be missing fonts icons... bootstrap looking for his fonts in his original folder see how gulp works at gulp/ folder

@liorkesos

This comment has been minimized.

Show comment
Hide comment
@liorkesos

liorkesos Aug 4, 2015

Member

@emps is right that is why we can now base it on the configuration - Made some preparations for this here - 96c06a5

Member

liorkesos commented Aug 4, 2015

@emps is right that is why we can now base it on the configuration - Made some preparations for this here - 96c06a5

@liorkesos

This comment has been minimized.

Show comment
Hide comment
@liorkesos

liorkesos Aug 6, 2015

Member

closing this

Member

liorkesos commented Aug 6, 2015

closing this

@liorkesos liorkesos closed this Aug 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment