moved bootstrap from head to assets as dependency #1290

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@VikramTiwari
Member

moving towards css frameworks as packages

@VikramTiwari VikramTiwari moved bootstrap from head to assets as dependency
8089c53
@emps
Contributor
emps commented Aug 1, 2015

this can make problems with bootstrap fonts

@VikramTiwari
Member

@emps Okay! But didn't understood why would it?

@shailendramonu

No font icons will be loaded after this change. Check on console...

On Saturday, 1 August 2015, Karol notifications@github.com wrote:

this can make problems with bootstrap fonts


Reply to this email directly or view it on GitHub
#1290 (comment).

Thanks & Regards,
Shailendra Singh

@emps
Contributor
emps commented Aug 1, 2015

@VikramTiwari cause all scripts in production mode gonna be at bower_components/build/* where will be missing fonts icons... bootstrap looking for his fonts in his original folder see how gulp works at gulp/ folder

@liorkesos
Member

@emps is right that is why we can now base it on the configuration - Made some preparations for this here - 96c06a5

@liorkesos
Member

closing this

@liorkesos liorkesos closed this Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment