Skip to content

feat: update add new helm chart #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 12, 2025
Merged

feat: update add new helm chart #524

merged 10 commits into from
Mar 12, 2025

Conversation

@ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented Mar 12, 2025 •
edited by dennisvankekem
Loading

Implement

https://jira.linode.com/browse/APL-556

Description

This PR updated the add new helm chart flow and components.
Is paired with: linode/apl-api#653

Screenshot

Screenshot 2025-03-12 at 09 07 07

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@ferruhcihan ferruhcihan mentioned this pull request Mar 12, 2025
Merged
@ferruhcihan ferruhcihan changed the title Apl 556 1 feat: update add new helm chart Mar 12, 2025
@dennisvankekem dennisvankekem self-assigned this Mar 12, 2025
dennisvankekem
dennisvankekem reviewed Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@dennisvankekem dennisvankekem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment to the regex. Rest of the code is looking good

@dennisvankekem
Copy link
Collaborator

dennisvankekem commented Mar 12, 2025

image

Do we want to re-add the card background ? This looks a bit incoherent perhaps

@dennisvankekem
Copy link
Collaborator

dennisvankekem commented Mar 12, 2025

image

when I resize the screen vertically part of the modal becomes inaccessible as it's not possible to scroll.

dennisvankekem
dennisvankekem requested changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@dennisvankekem dennisvankekem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some issues with responsiveness that needs to be fixed, most probably with a scrollbar of some sorts

@ferruhcihan
Copy link
Collaborator Author

ferruhcihan commented Mar 12, 2025

when I resize the screen vertically part of the modal becomes inaccessible as it's not possible to scroll.

some issues with responsiveness that needs to be fixed, most probably with a scrollbar of some sorts

Responsiveness is improved and scroll functionality is added.

@dennisvankekem
Copy link
Collaborator

dennisvankekem commented Mar 12, 2025

image

Do we want to re-add the card background ? This looks a bit incoherent perhaps

Will be fixed later in line with apps page

CasLubbers
CasLubbers approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 👍

ElderMatt
ElderMatt approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Cluster and it works great

@ferruhcihan ferruhcihan merged commit e5cd2d5 into main Mar 12, 2025
2 checks passed
@ferruhcihan ferruhcihan deleted the APL-556-1 branch March 12, 2025 16:31
ferruhcihan added a commit that referenced this pull request Mar 13, 2025
@ferruhcihan
feat: update add new helm chart (#524)
3d94fb2 
* feat: update add new helm chart

* feat: remove unnecessary lines

* fix: new chart modal

* fix: update new chart modal tests

* fix: new chart modal responsiveness

* feat: hide new chart modal scrollbar

* feat: add live check for the git repository url

* feat: update gitRepositoryUrlRegex

* feat: disable button based on git repository URL validation

* fix: new chart modal tests

(cherry picked from commit e5cd2d5)
ferruhcihan added a commit that referenced this pull request Mar 17, 2025
@ferruhcihan
chore: update main branch (#528)
38f184d 
* feat: hide code repositories pages (#526)

* feat: hide code repositories pages

* feat: add comment lines

(cherry picked from commit 852a340)

* feat: update add new helm chart (#524)

* feat: update add new helm chart

* feat: remove unnecessary lines

* fix: new chart modal

* fix: update new chart modal tests

* fix: new chart modal responsiveness

* feat: hide new chart modal scrollbar

* feat: add live check for the git repository url

* feat: update gitRepositoryUrlRegex

* feat: disable button based on git repository URL validation

* fix: new chart modal tests

(cherry picked from commit e5cd2d5)

* chore(release): 3.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElderMatt ElderMatt ElderMatt approved these changes

@CasLubbers CasLubbers CasLubbers approved these changes

@dennisvankekem dennisvankekem dennisvankekem approved these changes

Assignees

@dennisvankekem dennisvankekem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ferruhcihan @dennisvankekem @ElderMatt @CasLubbers