Skip to content

feat: hide code repositories pages #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2025
Merged

feat: hide code repositories pages #526

merged 3 commits into from
Mar 12, 2025

Conversation

@ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented Mar 12, 2025

This PR hides the code repositories pages.

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@CasLubbers
Copy link
Contributor

CasLubbers commented Mar 12, 2025

Maybe add TODO comment above all the commented out code so you wont miss anything when enabling?

@Ani1357 Ani1357 self-requested a review March 12, 2025 15:55
@ferruhcihan ferruhcihan enabled auto-merge (squash) March 12, 2025 16:36
@ferruhcihan ferruhcihan merged commit 852a340 into main Mar 12, 2025
2 checks passed
@ferruhcihan ferruhcihan deleted the hide-code-repositories branch March 12, 2025 16:42
ferruhcihan added a commit that referenced this pull request Mar 13, 2025
@ferruhcihan
feat: hide code repositories pages (#526)
5319c25 
* feat: hide code repositories pages

* feat: add comment lines

(cherry picked from commit 852a340)
ferruhcihan added a commit that referenced this pull request Mar 13, 2025
@ferruhcihan
feat: hide code repositories pages (#526)
3cd82bb 
* feat: hide code repositories pages

* feat: add comment lines

(cherry picked from commit 852a340)
ferruhcihan added a commit that referenced this pull request Mar 17, 2025
@ferruhcihan
chore: update main branch (#528)
38f184d 
* feat: hide code repositories pages (#526)

* feat: hide code repositories pages

* feat: add comment lines

(cherry picked from commit 852a340)

* feat: update add new helm chart (#524)

* feat: update add new helm chart

* feat: remove unnecessary lines

* fix: new chart modal

* fix: update new chart modal tests

* fix: new chart modal responsiveness

* feat: hide new chart modal scrollbar

* feat: add live check for the git repository url

* feat: update gitRepositoryUrlRegex

* feat: disable button based on git repository URL validation

* fix: new chart modal tests

(cherry picked from commit e5cd2d5)

* chore(release): 3.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CasLubbers CasLubbers CasLubbers approved these changes

@Ani1357 Ani1357 Ani1357 approved these changes

@j-zimnowoda j-zimnowoda Awaiting requested review from j-zimnowoda

@ElderMatt ElderMatt Awaiting requested review from ElderMatt

@dennisvankekem dennisvankekem Awaiting requested review from dennisvankekem dennisvankekem is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ferruhcihan @CasLubbers @Ani1357