-
Notifications
You must be signed in to change notification settings - Fork 63
[Update] Bumping up the version for side cars to latest available versions #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amold1
previously approved these changes
Sep 26, 2024
internal/driver/deploy/releases/linode-blockstorage-csi-driver.yaml
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage 53.02% 53.02%
=======================================
Files 22 22
Lines 1588 1588
=======================================
Hits 842 842
Misses 701 701
Partials 45 45 ☔ View full report in Codecov by Sentry. |
rahulait
reviewed
Sep 26, 2024
rahulait
previously approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
amold1
previously approved these changes
Sep 26, 2024
rahulait
reviewed
Sep 26, 2024
…it for pods to finish rolling out to new node
amold1
previously approved these changes
Sep 26, 2024
rahulait
approved these changes
Sep 26, 2024
amold1
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are removing args for the CSI driver image, the reason for that is we have moved away from setting flags for config and are supporting setting that using env var.
General:
Pull Request Guidelines: