Skip to content

Conversation

@komer3
Copy link
Contributor

@komer3 komer3 commented Sep 26, 2024

In this PR we are removing args for the CSI driver image, the reason for that is we have moved away from setting flags for config and are supporting setting that using env var.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@komer3 komer3 requested review from a team as code owners September 26, 2024 00:03
amold1
amold1 previously approved these changes Sep 26, 2024
@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.02%. Comparing base (db1d4b1) to head (734c9cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   53.02%   53.02%           
=======================================
  Files          22       22           
  Lines        1588     1588           
=======================================
  Hits          842      842           
  Misses        701      701           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rahulait
rahulait previously approved these changes Sep 26, 2024
Copy link
Contributor

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

amold1
amold1 previously approved these changes Sep 26, 2024
…it for pods to finish rolling out to new node
amold1
amold1 previously approved these changes Sep 26, 2024
@komer3 komer3 merged commit e54da7d into main Sep 26, 2024
9 checks passed
@komer3 komer3 deleted the version-upgrade branch September 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants