Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends on enum34, even for python3 #29

Open
ryantm opened this issue Jun 7, 2018 · 2 comments

Comments

@ryantm
Copy link

commented Jun 7, 2018

I was trying to package linode-cli for NixOS and I noticed a couple issues with the release artifacts. I'll post a separate issues about them.

The wheel archive metadata.json file says that run_requires enum34, but it looks like enum34 is only targeting a sub-set of the python versions this project is targeting. I'm not that familiar with how wheel archive metadata works, but it would be nice if it could be specified that enum34 is only necessary for python2 or whatever.

@ryantm ryantm changed the title depends on enum34 depends on enum34, even for python3 Jun 7, 2018

@Dorthu

This comment has been minimized.

Copy link
Member

commented Jun 11, 2018

Thanks for brining this up, I'll look into it and see what actually requires it. I believe you're correct in that it's only relevant for python2

@Dorthu Dorthu self-assigned this Jun 11, 2018

@cmorgenstern

This comment has been minimized.

Copy link

commented Mar 25, 2019

I encountered the same issue packaging linode-cli for Arch Linux. The end result was a failure to run under python3.7 due to enum34 not being present.

I ended up patching during the build to modify requirements.txt and setup.py with the following to get it to work:

requirements.txt

terminaltables
colorclass
requests
PyYAML
enum34; python_version < '3.4'

setup.py

install_requires=["terminaltables","colorclass","requests","PyYAML"],
extras_require={
    ":python_version<'3.4'": ['enum34'],
},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.