Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSH Plugin Smoke Tests #125

Merged
merged 27 commits into from May 13, 2019

Conversation

Projects
None yet
3 participants
@patthiel
Copy link
Contributor

commented May 8, 2019

  • Updated the dockerfile to install the actual version 1.1.0 of bats-core, after much frustration
  • Updated the until loops conditionals to the correct comparison form of [[
  • Added SSH Plugin smoke tests that i believe to be reasonably stable (based on some other tests we do for image packaging 馃檭 ).
  • Update common utilities to #!/usr/bin/env bash instead of #!/bin/bash since this will use the correct bash for your env instead of the default that's included with your system (helpful on OSX if you've installed a newer bash and have added that to your path).
  • Added DOCKER_BATS env var check for when running in a container.

To Test:

# Ensure you have bats-core installed. If not, brew install bats-core should do the trick.

# Uncomment the `.env.example` file and add your CLI Token(s) and save as `.env`

$ cd linode-cli/test
$ bats ssh/distro-and-connection-check.bats
$ bats ssh/ssh.bats

PM me to see test results on CI

@patthiel patthiel changed the title Add SSH Plugin CLI Smoke Tests Add SSH Plugin Smoke Tests May 8, 2019

@patthiel patthiel requested review from Dorthu and yoshizzle May 8, 2019

@patthiel patthiel added the test label May 8, 2019

@asheinz

asheinz approved these changes May 9, 2019

@Dorthu

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Can this be squashed ?

@patthiel

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@Dorthu absolutely.

@patthiel patthiel merged commit b32f458 into linode:master May 13, 2019

@patthiel patthiel deleted the patthiel:ARB-1195 branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.