New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow merging of settings when token is not present in config #90

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@alxbl
Copy link
Contributor

alxbl commented Dec 26, 2018

It turns out that using the environment variable to store the token can fail because the check for merging the configured settings and the command line supplied settings relies on token being present in the configuration. I hadn't noticed because I had already done a configure beforehand which stored a valid token in the DEFAULT user.

This PR fixes that issue by letting the configuration merge happen when the environment variable is defined.

Sorry for not catching this sooner! If you'd like me to open an issue for tracking purposes, let me know.

Cheers,

fix: Allow merging of settings when token is not present in configura…
…tion if it was supplied through environment variables.
Show resolved Hide resolved linodecli/configuration.py Outdated
@Dorthu

Dorthu approved these changes Jan 29, 2019

Copy link
Member

Dorthu left a comment

Tested this and it works great 👍 thank you

@Dorthu Dorthu merged commit 9c40864 into linode:master Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment