New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order imports update #3533

Merged
merged 25 commits into from Jul 11, 2018

Conversation

Projects
None yet
4 participants
@rjstires
Member

rjstires commented Jul 10, 2018

Purpose

Based on lively conversation in Slack I've updated TSLint and all src files to accommodate our import preferences.

Enjoy!

@rjstires rjstires self-assigned this Jul 10, 2018

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 10, 2018

Coverage Status

Coverage increased (+0.1%) to 26.822% when pulling 1cc728f on rjstires:order-imports-update into a741e8c on linode:develop.

coveralls commented Jul 10, 2018

Coverage Status

Coverage increased (+0.1%) to 26.822% when pulling 1cc728f on rjstires:order-imports-update into a741e8c on linode:develop.

@martinmckenna

perhaps documenting how we prefer imports to be ordered in the contributing.md file?

Show outdated Hide outdated src/features/Volumes/VolumeDrawer.tsx
Show outdated Hide outdated src/features/Volumes/Volumes.tsx
Show outdated Hide outdated src/events.ts

@rjstires rjstires closed this Jul 11, 2018

@rjstires rjstires deleted the rjstires:order-imports-update branch Jul 11, 2018

@rjstires rjstires restored the rjstires:order-imports-update branch Jul 11, 2018

@rjstires rjstires reopened this Jul 11, 2018

@rjstires rjstires merged commit 80b07bb into linode:develop Jul 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 26.822%
Details

@rjstires rjstires deleted the rjstires:order-imports-update branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment