New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Fixes - Stackscripts, domains, account permissions #3727

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
4 participants
@patthiel
Contributor

patthiel commented Aug 20, 2018

  • Addresses UI changes that caused a few e2e tests to break.

  • Update Specific Grants -> Specific Permissions

  • Update stackscripts tests to target an input selector instead of a textarea

  • Update create domain method to expect navigation to domain detail page after creation

  • Discovered clone domains bug logged in M3-1218 while testing.

To Test

yarn && yarn start
yarn selenium
yarn e2e --dir stackscripts # all should pass
yarn e2e --file e2e/specs/domains/list-domains.spec.js # two failures (due to M3-1218)
yarn e2e --file e2e/specs/account/view-update-permissions.spec.js # all should pass

@patthiel patthiel added the QA label Aug 20, 2018

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 20, 2018

Coverage Status

Coverage remained the same at 26.313% when pulling 0eeb53e on patthiel:08-20-test-maintenance into 97f4417 on linode:develop.

coveralls commented Aug 20, 2018

Coverage Status

Coverage remained the same at 26.313% when pulling 0eeb53e on patthiel:08-20-test-maintenance into 97f4417 on linode:develop.

@martinmckenna

I attempted yarn e2e --file e2e/specs/account/view-update-permissions.spec.js 3 times and only got all passing on the third attempt.

I think the issue was that the test username that was being used already existed because that's where the errors would begin.

@patthiel patthiel merged commit 72cea84 into linode:develop Aug 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 26.313%
Details
@patthiel

This comment has been minimized.

Show comment
Hide comment
@patthiel

patthiel Aug 21, 2018

Contributor

Tests passing consistently on my end. I will continue to monitor when these run on CI.

Contributor

patthiel commented Aug 21, 2018

Tests passing consistently on my end. I will continue to monitor when these run on CI.

@patthiel patthiel deleted the patthiel:08-20-test-maintenance branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment