New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Select Functional Test #3732

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
4 participants
@patthiel
Contributor

patthiel commented Aug 20, 2018

  • Adds a functional test for the enhanced select component
  • Note: I did not add tests for the arrow down/enter functionality, as those can be flaky on selenium. However, I have added a ticket to the backlog to add those once google chromedriver supports the actions api.

To Test

yarn storybook
yarn storybook:e2e --story EnhancedSelect
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 20, 2018

Coverage Status

Coverage decreased (-0.03%) to 26.285% when pulling 5ec67a8 on patthiel:M3-1141 into 04afb1b on linode:develop.

coveralls commented Aug 20, 2018

Coverage Status

Coverage decreased (-0.03%) to 26.285% when pulling 5ec67a8 on patthiel:M3-1141 into 04afb1b on linode:develop.

@martinmckenna
yarn storybook:e2e --story EnhancedSelect
yarn run v1.7.0
$ ./node_modules/.bin/wdio ./e2e/config/wdio.storybook.conf.js --story EnhancedSelect

․․․․

4 passing (4.10s)


✨  Done in 4.88s.

@patthiel patthiel merged commit 891f757 into linode:develop Aug 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 26.285%
Details

@patthiel patthiel deleted the patthiel:M3-1141 branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment