Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Python 3 fixes #73

Merged
merged 1 commit into from Aug 2, 2015

Conversation

@vstinner
Copy link
Contributor

commented Jul 27, 2015

  • Port set_multi() to Python 3
  • Port delete_multi() to Python 3
  • Fix _get_server() on Python 3 when the connection to the first server
    fails: encode to ASCII before calling serverHashFunction.
  • Fix expect(): don't decode line on Python 3, return the raw line
  • Add more unit tests
  • tox now also runs unit tests
  • Explicit the encoding when calling str.encode(): use 'utf-8'
  • test_memcache: close sockets in tearDown()
  • test_get_unknown_value(): delete the key to ensure that it doesn't exist
More Python 3 fixes
* Port set_multi() to Python 3
* Port delete_multi() to Python 3
* Fix _get_server() on Python 3 when the connection to the first server
  fails: encode to ASCII before calling serverHashFunction.
* Fix expect(): don't decode line on Python 3, return the raw line
* Add more unit tests
* tox now also runs unit tests
* Explicit the encoding when calling str.encode(): use 'utf-8'
* test_memcache: close sockets in tearDown()
* test_get_unknown_value(): delete the key to ensure that it doesn't exist
@linsomniac

This comment has been minimized.

Copy link
Owner

commented Aug 2, 2015

I've merged in some changes for Python 3, are all the issues that are in your patch covered by the current release?

@vstinner

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2015

This patch fixes bugs in the latest release. My previous python3 patch was not enough to fix all issues.

@linsomniac linsomniac merged commit 3fde65e into linsomniac:master Aug 2, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@linsomniac

This comment has been minimized.

Copy link
Owner

commented Aug 2, 2015

Ok, merged and fixed the test conflict.

@vstinner

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2015

Would it be possible to get a release including this pull request? python-memcached 1.57, the latest release, doesn't include the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.