Fixes for recent incomplete patches #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chucklever
commented
Oct 22, 2025
chucklever
commented
- Recent updates to playbooks/roles/volume_group to handle the new extra-volumes mechanism was bogus and incomplete.
- Modify generate_cloud_configs.py to update individual providers correctly
- detect_indentation_issues.py was complaining about the use of "tab-blank-blank" in Kconfig menu help texts
The script was detecting problems in Kconfig help text, where the lines begin with <tab><space><space>. Fix the script to cut down on false positives. Generated-by: Claude AI Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
This adds command-line argument support to allow generating Kconfig menus for specific cloud providers instead of always processing all providers. The script now accepts an optional --provider argument that can be set to lambdalabs, aws, azure, gce, or oci to generate configuration for only that provider. When no --provider argument is specified, the script maintains backward compatibility by generating configs for all providers. This improves the user experience when working with a specific cloud provider and reduces unnecessary API calls and processing time. Generated-by: Claude AI Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Utilize the new command-line argument to generate_cloud_configs.py to enable users and scripts to generate only one provider's Kconfig menus. This appears to have been the intent for Lambda Labs, but was never implemented fully. Generated-by: Claude AI Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Commit 9d6332c ("volume_group: Use cloud provider's default data disk") was incomplete. Take full advantage of the new mechanism to determine which EBS devices are available for use by kdevops. Fixes: 9d6332c ("volume_group: Use cloud provider's default data disk") Assisted-by: Claude AI Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.