Skip to content

Add soversion to the library build.#2

Merged
flamingradian merged 1 commit into
linux-msm:mainfrom
xelageo:wip/alex/soversion
Oct 16, 2024
Merged

Add soversion to the library build.#2
flamingradian merged 1 commit into
linux-msm:mainfrom
xelageo:wip/alex/soversion

Conversation

@xelageo

@xelageo xelageo commented Oct 5, 2024

Copy link
Copy Markdown
Contributor

This add a soversion to the libhexagonrpc, allowing easier upgrade when changing the ABI and would allow a much more standard way to package it in debian.
Meson will generate libhexagonrpc.so.0 and symlink to libhexagonrpc.so
A working debian package with the patch is available at https://salsa.debian.org/xela/hexagonrpc/-/blob/debian/latest/

@flamingradian

Copy link
Copy Markdown
Collaborator

Could this be done instead with the version argument and the version of HexagonRPC? Breaking changes could happen between 0.3.0 and 0.4.0.

@xelageo

xelageo commented Oct 15, 2024

Copy link
Copy Markdown
Contributor Author

Sure, I added a version variable in the main meson.build, and use it as parameters for the lib soversion.
Now the build output a libhexagonrpc.so.0.3.2 and its symlink to libhexagonrpc.so.

Comment thread meson.build
@@ -1,4 +1,5 @@
project('fastrpc', 'c')
version = '0.3.2'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line above this one, just because the project() line needs to be at the top, and the variable doesn't need to be.

Other than that, LGTM (commits will be squashed).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the blank line. Would you like I squash them in my PR branch or GitHub does it automatically ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll squash them manually so I can still sign the commit. Your authorship will be preserved.

@flamingradian flamingradian merged commit 2415d5f into linux-msm:main Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants