bootctrl: fall back to active slot if current slot not found in cmdline#1
bootctrl: fall back to active slot if current slot not found in cmdline#1a-wai wants to merge 0 commit into
Conversation
|
Sorry i totally missed this PR! Not sure how motivated you are still with this, the diff needs fixing (is it necessary to move the function?) and I think it would make sense to adjust the function name to reflect the fallback behaviour. I can also make these changes while merging given the timespan... |
Well it has to know about
Sure, do you have something specific in mind? |
|
OK I'm not sure what the heck I did here, github just wouldn't let me push to the PR. I adjusted this slightly and pushed it to main in 413ee35 |
Btw is this supposed to technically fix the soft bricking issue if using any other distro apart pmos as in pmos it works fine as in arch ir corrupts lun and gpt tables. |
While postmarketOS makes use of a kernel cmdline argument, this isn't the case for all distros. Furthermore, this argument isn't present in those added automatically by the Android bootloader.
In order to still be able to use
qbootctlon other distros, this change ensures we use the currently active slot as the current slot when the cmdline argument is missing. This ensureqbootctl -mpicks up the correct slot more often than not, instead of always defaulting to_a.