Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use utmpx where available #52

Open
wants to merge 6 commits into
base: master
from
Open

Conversation

@awilfox
Copy link

@awilfox awilfox commented Jun 16, 2018

On the musl libc, utmp is unimplemented. The utmps library by skarnet provides utmpx functionality on musl, but not utmp. This pull request modifies Linux PAM to support user accounting on musl distros that link it to utmps, by using <utmpx.h> instead of <utmp.h> if HAVE_UTMPX_H is defined in config.h.

On glibc, utmpx and utmp are aliases, so there is no functional change there.

awilfox added 6 commits Jun 16, 2018
@t8m
Copy link
Member

@t8m t8m commented Feb 18, 2020

I am concerned about making the utmpx calls as the default. They should be done only for the MUSL case.

@t8m t8m added the needschange label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.