From 32921520e79661cc4f75d323d83f01e32c54922f Mon Sep 17 00:00:00 2001 From: Kamal Heib Date: Fri, 22 Sep 2023 10:55:04 -0400 Subject: [PATCH] providers/bnxt_re: Fix bnxt_re_alloc_queue_ptr error flow [ Upstream commit accaf33d8138c046d07595e2891936b20f171e7a ] Make sure to free the "qp->jsqq" pointer in the right place. Fixes: f92837e29fd4 ("bnxt_re/lib: consolidate hwque and swque in common structure") Signed-off-by: Kamal Heib Signed-off-by: Nicolas Morey --- providers/bnxt_re/verbs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/providers/bnxt_re/verbs.c b/providers/bnxt_re/verbs.c index be1f43305..c7e6e6d9b 100644 --- a/providers/bnxt_re/verbs.c +++ b/providers/bnxt_re/verbs.c @@ -849,10 +849,9 @@ static int bnxt_re_alloc_queue_ptr(struct bnxt_re_qp *qp, if (!attr->srq) { qp->jrqq = calloc(1, sizeof(struct bnxt_re_joint_queue)); - if (!qp->jrqq) { - free(qp->jsqq); + if (!qp->jrqq) goto fail; - } + qp->jrqq->hwque = calloc(1, sizeof(struct bnxt_re_queue)); if (!qp->jrqq->hwque) goto fail;