Browse files

move_pages09: move_pages returns 0 if nothing got migrated

Following commit changed the behavior to return 0 when no pages
require migration.

commit e78bbfa8262424417a29349a8064a535053912b9
Author: Brice Goglin <Brice.Goglin@inria.fr>
Date:   Sat Oct 18 20:27:15 2008 -0700
    mm: stop returning -ENOENT from sys_move_pages() if nothing got
migrated

So testing for ENOENT in move_pages09, makes sense only for
kernel < 2.6.28.

Signed-off-by: Jan Stancek <jstancek@redhat.com>
Acked-by: Caspar Zhang <caspar@casparzhang.com>
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
  • Loading branch information...
1 parent 6e8e2be commit 338299da1ff27c7815183c1b07eb91e705f117ce @gaowanlong gaowanlong committed May 9, 2012
Showing with 20 additions and 7 deletions.
  1. +20 −7 testcases/kernel/syscalls/move_pages/move_pages09.c
View
27 testcases/kernel/syscalls/move_pages/move_pages09.c
@@ -105,12 +105,25 @@ int main(int argc, char **argv)
ret = numa_move_pages(0, TEST_PAGES, pages, nodes,
status, MPOL_MF_MOVE);
TEST_ERRNO = errno;
- if (ret == -1 && errno == ENOENT)
- tst_resm(TPASS, "move_pages failed with "
- "ENOENT as expected");
- else
- tst_resm(TFAIL, "move pages did not fail "
- "with ENOENT");
+
+ /*
+ * commit e78bbfa8262424417a29349a8064a535053912b9
+ * Author: Brice Goglin <Brice.Goglin@inria.fr>
+ * Date: Sat Oct 18 20:27:15 2008 -0700
+ * mm: stop returning -ENOENT from sys_move_pages() if nothing got migrated
+ */
+ if ((tst_kvercmp(2, 6, 28)) >= 0) {
+ if (ret == 0)
+ tst_resm(TPASS, "move_pages succeeded");
+ else
+ tst_resm(TFAIL|TERRNO, "move_pages");
+ } else {
+ if (ret == -1 && errno == ENOENT)
+ tst_resm(TPASS, "move_pages failed with "
+ "ENOENT as expected");
+ else
+ tst_resm(TFAIL|TERRNO, "move_pages");
+ }
free_pages(pages, TEST_PAGES);
}
@@ -150,4 +163,4 @@ void cleanup(void)
*/
TEST_CLEANUP;
- }
+ }

0 comments on commit 338299d

Please sign in to comment.