-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X230 suspend #608
Comments
Update: the problem does not occur if I extract fallback/payload from the heads ROM file and inject it into vanilla coreboot's ROM, then run the heads payload through the SeaBIOS's boot menu. |
yes. suspend and resume on the X230 is simply broken in coreboot 4.8, which is old, but still used in current builds of Heads. This will be fixed when we use coreboot 4.10 or later. |
Should I try rebuilding with coreboot 4.10 by just changing version (and hash) inside modules/coreboot ? |
nope. it's quite some work to do that (dealing with the Heads-patches on top of coreboot). in fact there've been numerous issues/PRs starting to do that. one needs to take time, start over and finish that work. |
I do not see this behavior in QubesOS with 4.8.1 in my branch?
…On September 23, 2019 7:08:01 AM UTC, Martin Kepplinger ***@***.***> wrote:
yes. suspend and resume on the X230 is simply broken in coreboot 4.8,
which is old, but still used in current builds of Heads. This will be
fixed when we use coreboot 4.10 or later.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#608 (comment)
-- Sent from /e/ Mail
|
@merge This question might be a little bit out of scope of this issue, but Is there a place where I can check which patches are those and why they are there? |
@gordon-quad : The answer to your question can be found here If you have questions about this, please open another issue. |
Was working in same coreboot version before (4.8.1). Not sure what is happening here |
@gordon-quad : That would need coreboot patches or equivalent to take benefit of measured boot, which never landed on coreboot for Ivy/Sandy bridges, which #605 #721 #709 are about. |
@PatrickRudolph do you have a quote to fix this resume from suspend issue still present under coreboot 4.12 (measured boot, not VBOOT+measured boot) testing builds (based on #721) ? This can be tested from here https://app.circleci.com/pipelines/github/tlaurion/heads/303/workflows/55b002ed-357f-42da-9de7-5af4e66f8828/jobs/329/artifacts on x230. x230-htop-verification internal flashable rom (BIOS region only) is here: https://329-103208611-gh.circle-artifacts.com/0/build/x230-hotp-verification/coreboot.rom |
Tested https://github.com/Thrilleratplay/coreboot-builder-scripts Result: no suspend resume problem.
|
…" by disabling board "CONFIG_DROPBEAR=y" and "CONFIG_LINUX_E1000E" to save space per @alex-nitrokey test under linuxboot#770 to fix linuxboot#608
Successfull build per tlaurion@b1886f3 If it works, it means that the maximum space available in CBFS for BIOS is really 0x700000 (I remember I did the calculations somewhere under Heads....) EDIT: explanation is here I'll try to test in next test batch @alex-nitrokey |
…" by disabling board "CONFIG_DROPBEAR=y" and "CONFIG_LINUX_E1000E" to save space per @alex-nitrokey test under linuxboot#770 to fix linuxboot#608
fixed under 30852aa |
I am having issue with Thinkpad X230 suspend when OS is booted using Heads.
When I try to suspend my laptop, running Linux 5.2.11-arch1-1-ARCH, it disables the backlight (as usual), but instead of suspending after a second enables the backlight again, delays for a few seconds, and then disables the backlight and finally suspends.
On resume the backlight does not enable immediately — I see a delay of a few seconds, then the backlight enables and I see the VT screen, but the CPU fan is running at 100% and the system is immensely slow — echoing a single character typed on a keyboard takes about a minute.
No such problem occurs on a vanilla coreboot 563b869 with SeaBIOS and Intel VBT.
The text was updated successfully, but these errors were encountered: