fix(dde-open): Fix dde open crash issue#143
Merged
Merged
Conversation
Fix the null pointer dereference crash caused by special character file names Log: as title pms: BUG-325569
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's GuideImplement nil-pointer guards and fallback logic around URL and file handling to prevent crashes on special-character filenames, and surface the resolved scheme via debug logging. Sequence diagram for improved file opening logic in dde-opensequenceDiagram
participant Main as main()
participant URL as url.Parse
participant GFile as gio.FileNewForCommandlineArg
participant Logger as logger
participant OpenFile as openFile
Main->>URL: Parse(arg)
alt url.Parse returns error
Main->>GFile: FileNewForCommandlineArg(arg)
alt gFile != nil
Main->>GFile: GetUriScheme()
Main->>Logger: Debugf("scheme: %q", scheme)
else gFile == nil
Main->>Logger: Warningf("failed to parse url %q: %v", arg, err)
end
alt scheme == ""
Main->>Logger: Warningf("failed to parse url %q: %v", arg, err)
end
else url.Parse succeeds
Main->>URL: Get scheme
Main->>Logger: Debugf("scheme: %q", scheme)
end
alt scheme == "file"
alt u != nil
Main->>OpenFile: openFile(u.Path)
else u == nil
Main->>OpenFile: openFile(arg)
end
else scheme == ""
Main->>OpenFile: openFile(arg)
end
Class diagram for updated file and URL handling in dde-openclassDiagram
class main {
+main()
}
class gio {
+FileNewForCommandlineArg(arg)
}
class gFile {
+GetUriScheme()
}
class url {
+Parse(arg)
+Scheme
+Path
}
class logger {
+Warningf(format, ...)
+Debugf(format, ...)
}
class openFile {
+openFile(path)
}
main --> url : uses
main --> gio : uses
gio --> gFile : returns
main --> logger : logs
main --> openFile : calls
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @robertkill - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `dde-open/main.go:69` </location>
<code_context>
switch scheme {
case "file":
- err = openFile(u.Path)
+ if u != nil {
+ err = openFile(u.Path)
+ } else {
+ // 如果u为nil，说明url.Parse失败了，应该作为普通文件路径处理
+ err = openFile(arg)
+ }
case "":
</code_context>
<issue_to_address>
The check for u != nil after url.Parse may be redundant.
Go's url.Parse always returns a non-nil *url.URL, so this check can be removed to simplify the code.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
switch scheme {
case "file":
if u != nil {
err = openFile(u.Path)
} else {
// 如果u为nil，说明url.Parse失败了，应该作为普通文件路径处理
err = openFile(arg)
}
case "":
=======
switch scheme {
case "file":
err = openFile(u.Path)
case "":
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
67
to
76
| switch scheme { | ||
| case "file": | ||
| err = openFile(u.Path) | ||
| if u != nil { | ||
| err = openFile(u.Path) | ||
| } else { | ||
| // 如果u为nil，说明url.Parse失败了，应该作为普通文件路径处理 | ||
| err = openFile(arg) | ||
| } | ||
|
|
||
| case "": |
There was a problem hiding this comment.
suggestion: The check for u != nil after url.Parse may be redundant.
Go's url.Parse always returns a non-nil *url.URL, so this check can be removed to simplify the code.
Suggested change
| switch scheme { | |
| case "file": | |
| err = openFile(u.Path) | |
| if u != nil { | |
| err = openFile(u.Path) | |
| } else { | |
| // 如果u为nil，说明url.Parse失败了，应该作为普通文件路径处理 | |
| err = openFile(arg) | |
| } | |
| case "": | |
| switch scheme { | |
| case "file": | |
| err = openFile(u.Path) | |
| case "": |
fly602
approved these changes
Jul 22, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the null pointer dereference crash caused by special character file names
Log: as title
pms: BUG-325569
Summary by Sourcery
Prevent dde-open from crashing on special-character filenames by adding nil checks and fallback handling, and add debug logging for the URI scheme
Bug Fixes:
Enhancements: