chore: missing some translations for notification#1088
Conversation
as title. pms: BUG-289337
Reviewer's Guide by SourceryThis pull request adds missing translations, updates existing translations for accuracy and grammar, and syncs translation files with source code for the notification center in multiple languages. It also introduces a specific translation for '1 hour ago'. Updated class diagram for AppNotifyItemclassDiagram
class AppNotifyItem {
- QDateTime time
- int elapsedSeconds
+ void updateTime()
+ QString getFormattedTime()
}
note for AppNotifyItem "Updates to updateTime() to include specific translation for '1 hour ago'"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you've added a translation for '1 hour ago', but haven't translated it in all the files.
- The location of some strings has changed, which might require translators to re-translate some strings.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
as title.
pms: BUG-289337
Summary by Sourcery
Update translations for notification center with missing translations and time-related improvements
Enhancements:
Chores: