fix: correct SPDX comment syntax in DDEShellDockConfig.cmake.in#1575
Merged
Conversation
Changed the SPDX license header from C++ style `//` comments to CMake `#` style comments to match the file's CMake language syntax, ensuring proper SPDX license handling. Log: Fixed SPDX license comment syntax in CMake configuration file Influence: 1. Verify SPDX license header parsing tools recognize the corrected syntax 2. Confirm CMake build system processes the file without warnings 3. Ensure no functional impact on the dock panel configuration fix: 修正 DDEShellDockConfig.cmake.in 中 SPDX 注释语法 将 SPDX 许可证头从 C++ 风格的 `//` 注释改为 CMake 风格的 `#` 注释,以匹 配文件的 CMake 语言语法,确保 SPDX 许可证的正确处理。 Log: 修复 CMake 配置文件中的 SPDX 许可证注释语法 Influence: 1. 验证 SPDX 许可证头解析工具能识别修正后的语法 2. 确认 CMake 构建系统处理该文件时无警告 3. 确保对 Dock 面板配置无功能影响
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the SPDX license header in DDEShellDockConfig.cmake.in to use CMake-style File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
BLumia
approved these changes
Apr 29, 2026
18202781743
approved these changes
Apr 29, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin pr auto review这段代码是对 CMake 配置文件 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
总结与改进建议这段 diff 是一个修正性提交,修复了 CMake 文件中的语法错误。 改进建议:
修改后的代码片段(修正年份假设): # SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
#
# SPDX-License-Identifier: GPL-3.0-or-later
@PACKAGE_INIT@
include(CMakeFindDependencyMacro) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the SPDX license header from C++ style
//comments to CMake#style comments to match the file's CMake language syntax, ensuring proper SPDX license handling.Log: Fixed SPDX license comment syntax in CMake configuration file
Influence:
fix: 修正 DDEShellDockConfig.cmake.in 中 SPDX 注释语法
将 SPDX 许可证头从 C++ 风格的
//注释改为 CMake 风格的#注释,以匹 配文件的 CMake 语言语法,确保 SPDX 许可证的正确处理。Log: 修复 CMake 配置文件中的 SPDX 许可证注释语法
Influence:
Summary by Sourcery
Enhancements:
#comment syntax for proper tooling recognition.