Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: arm64 support [ci-skip] [not for merge] #1654

Closed
wants to merge 29 commits into from

Conversation

mor1
Copy link
Contributor

@mor1 mor1 commented Apr 18, 2017

This PR is not for merge but is the starting point for ARM64 support.
It has now successfully built a kernel and initrd that have booted a packet.net ARM64 box.

@AkihiroSuda
Copy link
Contributor

AkihiroSuda commented Apr 25, 2017

Can we deduplicate kernel/Dockerfile,Makefile,kernel_config across all the platforms?

i.e.

  • kernel/Dockerfile: universal Dockerfile, accepts specifying ARCH via build-arg
  • Makefile: ditto via make ARCH=...
  • kernel_config: common parts across all the archs
  • kernel_config.{x86_64,arm64,...}: architecture-specific part. Concatinated to kernel_config in the build container

@rn
Copy link
Member

rn commented Apr 25, 2017

@AkihiroSuda hopefully today I'll tidy up the kernel build a little and that might make it easier to dedup

Makefile Outdated

MOBY?=bin/moby
LINUXKIT?=bin/linuxkit
GOOS=$(shell uname -s | tr '[:upper:]' '[:lower:]')
GOARCH=amd64
GOARCH=arm64
Copy link
Member

@justincormack justincormack Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not be setting this unconditionally, you should use uname to find it

mor1 added 8 commits Apr 29, 2017
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
mor1 added 4 commits Apr 29, 2017
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
@GordonTheTurtle
Copy link
Collaborator

GordonTheTurtle commented Apr 29, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "project-arm64" git@github.com:mor1/linuxkit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354472624
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Richard Mortier <mort@cantab.net>
mor1 added 11 commits May 2, 2017
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
mor1 added 3 commits May 8, 2017
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
Signed-off-by: Richard Mortier <mort@cantab.net>
@mor1 mor1 mentioned this pull request May 17, 2017
5 tasks
Signed-off-by: Richard Mortier <mort@cantab.net>
@zlim
Copy link
Contributor

zlim commented Jun 26, 2017

cc @arm64b

@justincormack
Copy link
Member

justincormack commented Jul 12, 2017

Going to close this as parts of arm64 are now being merged in and this does not apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants