Split cli into moby and linuxkit #1695

Merged
merged 1 commit into from Apr 24, 2017

Conversation

Projects
None yet
6 participants
@justincormack
Collaborator

justincormack commented Apr 24, 2017

moby just does the simple build cases, while linuxkit does
push and run.

This allows splitting out just moby.

Signed-off-by: Justin Cormack justin.cormack@docker.com

@riyazdf

awesome, LGTM

@justincormack

This comment has been minimized.

Show comment
Hide comment
@justincormack

justincormack Apr 24, 2017

Collaborator

Amended the README too to refer to the new tools.

Collaborator

justincormack commented Apr 24, 2017

Amended the README too to refer to the new tools.

@@ -15,17 +15,18 @@ LinuxKit, a toolkit for building custom minimal, immutable Linux distributions.
## Getting Started
-### Build the `moby` tool
+### Build the `moby` and `linuxkit` tools

This comment has been minimized.

@riyazdf

riyazdf Apr 24, 2017

Contributor

Should we add a brief explanation of the difference between the linuxkit and moby tools? I realize we'll continue to shuffle things around but might be helpful in the intermediate stage

@riyazdf

riyazdf Apr 24, 2017

Contributor

Should we add a brief explanation of the difference between the linuxkit and moby tools? I realize we'll continue to shuffle things around but might be helpful in the intermediate stage

This comment has been minimized.

@deitch

deitch Apr 25, 2017

Collaborator

I still am trying to wrap my head around it. Is the short form: moby is a tool for building images, and linuxkit is a tool for pushing and running images? So moby == docker build and linuxkit == docker run / docker push?

And if so... why? What do we gain by having 2 distinct tools?

@deitch

deitch Apr 25, 2017

Collaborator

I still am trying to wrap my head around it. Is the short form: moby is a tool for building images, and linuxkit is a tool for pushing and running images? So moby == docker build and linuxkit == docker run / docker push?

And if so... why? What do we gain by having 2 distinct tools?

This comment has been minimized.

@rn

rn Apr 25, 2017

Member

yes. And the moby tool will be moved and extended to build assemblies other than linux images. This was discussed at length at DockerCon and various meetings after. I'm not sure there is a good writeup yet

@rn

rn Apr 25, 2017

Member

yes. And the moby tool will be moved and extended to build assemblies other than linux images. This was discussed at length at DockerCon and various meetings after. I'm not sure there is a good writeup yet

@rn

rn approved these changes Apr 24, 2017

I agree with @riyazdf that a short explanation in the toplevel readme about the difference between the moby and linuxkit tools would be good, but otherwise LGTM

Split cli into moby and linuxkit
moby just does the simple `build` cases, while `linuxkit` does
`push` and `run`.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
@justincormack

This comment has been minimized.

Show comment
Hide comment
@justincormack

justincormack Apr 24, 2017

Collaborator

Added a very short explanation, will expand when split out (soon).

Collaborator

justincormack commented Apr 24, 2017

Added a very short explanation, will expand when split out (soon).

@justincormack justincormack merged commit b78b5a7 into linuxkit:master Apr 24, 2017

2 checks passed

ci/datakit/build All tests passed
Details
dco-signed All commits are signed

@justincormack justincormack deleted the justincormack:split-cli branch Apr 24, 2017

@alexellis

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment