New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s390x support to binfmt_misc #3253

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@johanneswuerbach
Copy link

johanneswuerbach commented Dec 22, 2018

- What I did

Register s390x with binfmt_misc and add the static qemu s390x binary. Docker already provides
official images for s309x (but no official support).

https://github.com/docker-library/official-images#architectures-other-than-amd64

- How I did it

While the process wasn't really documented before, I added some details around adding an architecture.

- How to verify it

docker build -t binfmt ./pkg/binfmt
docker run --rm -it --privileged binfmt
docker run --rm -it s390x/debian:stretch uname -a
Linux 989516accfdd 4.9.125-linuxkit #1 SMP Fri Sep 7 08:20:28 UTC 2018 s390x GNU/Linux

- Description for the changelog

Add support for cross-building s390x images

- A picture of a cute animal (not mandatory but encouraged)

image

What would be the process to have this eventually supported in docker for mac besides bumping the image here https://github.com/linuxkit/linuxkit/blob/master/examples/docker-for-mac.yml#L20?

@johanneswuerbach johanneswuerbach changed the title Add s390x support to binfmt Add s390x support to binfmt_misc Dec 22, 2018

@johanneswuerbach johanneswuerbach force-pushed the johanneswuerbach:s390x-support branch 2 times, most recently from eef5d1a to 89a7fbe Dec 22, 2018

Add s390x support to binfmt_misc
Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

@johanneswuerbach johanneswuerbach force-pushed the johanneswuerbach:s390x-support branch from 89a7fbe to 81d17a1 Dec 22, 2018

@deitch

This comment has been minimized.

Copy link
Collaborator

deitch commented Dec 23, 2018

I do like having this, thank you @johanneswuerbach

There were some issues with qemu-s390x-static not working correctly. I came across them most recently when I was working to get calico cross-platform, but I cannot recall what they were at the moment. It has been a bit of time, but I found my own (unfortunately cryptic) comment here, but cannot recall what the issues were. Something about binaries giving a strange SIGSEGV due to qemu emulation issues? The exclusion exists in every calico project, I remember having to exclude it, but cannot recall the details now.

I do recall that we worked with @alicefr on it, as well as @mkumatag . Does either of you recall what the qemu s390x issues were?

@justincormack

This comment has been minimized.

Copy link
Collaborator

justincormack commented Dec 23, 2018

The original reason for not adding this was that IBM had some legal issues with s390 emulation, not sure if this is really an issue or not any more.

@deitch

This comment has been minimized.

Copy link
Collaborator

deitch commented Dec 23, 2018

IBM had some legal issues with s390 emulation,

Then we may have a technical issue and a legal issue. Hopefully Alice or Manjunath can shed light on the technical ones. Do you know who can answer the legal ones?

@thaJeztah

This comment has been minimized.

Copy link
Contributor

thaJeztah commented Dec 23, 2018

Do you know who can answer the legal ones?

Perhaps @estesp ?

@mkumatag

This comment has been minimized.

Copy link

mkumatag commented Dec 24, 2018

@cwsolee do you know anyone who can help us here?

@cwsolee

This comment has been minimized.

Copy link

cwsolee commented Dec 24, 2018

I'm been away, Alice might have more recent news on whether they can work on it.

@alicefr

This comment has been minimized.

Copy link
Contributor

alicefr commented Jan 7, 2019

hi everybody! Unfortunately, the legal issues are still there. User emulation as far as I know should work fine, it is the system emulation that have issues. Sorry this doesn't help much, I know

@justincormack

This comment has been minimized.

Copy link
Collaborator

justincormack commented Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment